Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to customize the loading indicator #12

Open
M-HARIS-97 opened this issue Nov 21, 2022 · 4 comments
Open

[Feature Request] Ability to customize the loading indicator #12

M-HARIS-97 opened this issue Nov 21, 2022 · 4 comments

Comments

@M-HARIS-97
Copy link

How can I change the initial loading activity indicator?

@jspizziri
Copy link
Contributor

@M-HARIS-97 in order to accomplish this some features would need to be built into the library. There are two ways of doing it as I see it:

On the React Side

On the native side, a new callback would be built into the library like onLoading: (isLoading: boolean) => void. You'd pass a function to listen for that event, and when loading is triggered, you'd build your own loading UI on the react/js side.

On the Native Side

There's probably a way to pass a loading element into the native code by reference or something and have the native side use that when loading. However, I'm not 100% sure how to pull that off, so I'd require a bit more research on my end. Might be a heavier lift as a result.

@jspizziri jspizziri changed the title How to change the initial loading content? [Feature Request] Ability to customize the loading indicator Nov 21, 2022
@M-HARIS-97
Copy link
Author

How to remove the activity indicator directly from the package for the mean time? Is that possible?

@jspizziri
Copy link
Contributor

@M-HARIS-97 that is currently not possible. It would also require a feature to pass a boolean like isNativeLoaderDisplayed or something.

@M-HARIS-97
Copy link
Author

@jspizziri okay; thanks for the update.

@jspizziri jspizziri moved this to 📋 Scheduled in react-native-readium Dec 15, 2022
@jspizziri jspizziri moved this from 📋 Scheduled to 📆 Backlog in react-native-readium Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📆 Backlog
Development

No branches or pull requests

2 participants