Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership of Snakemake tibanna plugin #394

Open
johanneskoester opened this issue Sep 11, 2023 · 11 comments
Open

Transfer ownership of Snakemake tibanna plugin #394

johanneskoester opened this issue Sep 11, 2023 · 11 comments

Comments

@johanneskoester
Copy link

johanneskoester commented Sep 11, 2023

As you might have heard, the upcoming Snakemake 8.0 will get support for execution backend plugins (snakemake/snakemake#2409). I have therefore moved the tibanna executor of Snakemake, which was originally developed by @SooLee, into a dedicated plugin: https://github.com/snakemake/snakemake-executor-plugin-tibanna.

The plugin comes with a test framework. Given that you have AWS testing properly set up here, I would love to see the plugin be owned by @4dn-dcic. If you agree, I am happy to transfer the ownership of the plugin from the Snakemake organization to 4dn-dcic. I would be delighted to help with setting up the tests and fix any bugs that I might have introduced with my migration of @SooLee's code into the plugin.

@willronchetti
Copy link
Member

Thanks so much for doing this! We would be happy to take ownership of the plugin, and we would welcome contributions in consultation with us to get some tests up for it. If you have ideas for integrated tests we can certainly use our testing account for those. Feel free to request the ownership transfer and I will approve it.

@johanneskoester
Copy link
Author

Awesome! So, I tried but it seems permissions don't allow this properly. If you could create public repo here, called snakemake-executor-plugin-tibanna? I will create a PR that adds the source code then.

@willronchetti
Copy link
Member

I've gone ahead and created an empty repository under 4dn-dcic here: https://github.com/4dn-dcic/snakemake-executor-plugin-tibanna

Feel free to make the PR!

@johanneskoester
Copy link
Author

Seems like it needs one file in it to allow me forking it :-). Can you add an empty README.md?

@johanneskoester
Copy link
Author

Wait, much simpler solution! I will make you admin of the original repo, and you transfer the ownership to here. Give me a second.

@johanneskoester
Copy link
Author

Done, once you have accepted the invitation, you should be able to transfer the repo, given that you first delete the empty one you just created. Sorry for the hassle.

@willronchetti
Copy link
Member

Thanks for doing that, I went ahead and transferred ownership into our org, you can find it at the same link here: https://github.com/4dn-dcic/snakemake-executor-plugin-tibanna

@laurentiush
Copy link

laurentiush commented Jul 15, 2024

Hi, as far as I can see Tibanna does not work with Snakemake 8.0 or later because the plugin is not yet available. Do you have an idea when the executor plugin will become available, so that it is possible to use more recent versions of Snakemake with Tibanna?

@scoulondre
Copy link

Hi, as far as I can see Tibanna does not work with Snakemake 8.0 or later because the plugin is not yet available. Do you have an idea when the executor plugin will become available, so that it is possible to use more recent versions of Snakemake with Tibanna?

The most recent combination of snakemake + tibanna that I could set up is snakemake==7.32.4 and tibanna==5.4.3
I am afraid tibanna is dying and I am thinking of migrating to snakemake + kubernetes.
Just my 2 cents...

@SooLee
Copy link
Member

SooLee commented Oct 18, 2024 via email

@willronchetti
Copy link
Member

willronchetti commented Oct 18, 2024

@SooLee @alexander-veit I am currently transitioning to a new position, so I think this is a question better suited for Alex, but my impression is we are generally very busy with SMaHT and could use the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants