Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.4.1 #212

Closed
lloydowen opened this issue Dec 23, 2024 · 1 comment
Closed

Support PHP 8.4.1 #212

lloydowen opened this issue Dec 23, 2024 · 1 comment

Comments

@lloydowen
Copy link

Since PHP 8.4.1 there are lots of deprecated warnings. Whilst they are only warnings we should look to fix them.

PHP Deprecated:  can_impersonate(): Implicitly marking parameter $guard as nullable is deprecated, the explicit nullable type must be used instead in /Users/lloyd/Documents/work/clear/*/vendor/lab404/laravel-impersonate/src/helpers.php on line 13

Deprecated: can_impersonate(): Implicitly marking parameter $guard as nullable is deprecated, the explicit nullable type must be used instead in /Users/lloyd/Documents/work/clear/*/vendor/lab404/laravel-impersonate/src/helpers.php on line 13
PHP Deprecated:  can_be_impersonated(): Implicitly marking parameter $guard as nullable is deprecated, the explicit nullable type must be used instead in /Users/lloyd/Documents/work/clear/*/vendor/lab404/laravel-impersonate/src/helpers.php on line 31

Deprecated: can_be_impersonated(): Implicitly marking parameter $guard as nullable is deprecated, the explicit nullable type must be used instead in /Users/lloyd/Documents/work/clear/*/vendor/lab404/laravel-impersonate/src/helpers.php on line 31
PHP Deprecated:  is_impersonating(): Implicitly marking parameter $guard as nullable is deprecated, the explicit nullable type must be used instead in /Users/lloyd/Documents/work/clear/*/vendor/lab404/laravel-impersonate/src/helpers.php on line 48

Deprecated: is_impersonating(): Implicitly marking parameter $guard as nullable is deprecated, the explicit nullable type must be used instead in /Users/lloyd/Documents/work/clear/***/vendor/lab404/laravel-impersonate/src/helpers.php on line 48

I believe this is a fairly easy fix.

@drbyte
Copy link
Contributor

drbyte commented Dec 23, 2024

Looks like a duplicate of #211 and #209

@lloydowen lloydowen closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants