Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to specify slower speed transition #852

Open
kfarr opened this issue Sep 10, 2024 · 2 comments
Open

ability to specify slower speed transition #852

kfarr opened this issue Sep 10, 2024 · 2 comments

Comments

@kfarr
Copy link
Collaborator

kfarr commented Sep 10, 2024

as a user making a presentation or video from my 3dstreet scene, i'd like to slow down the transition speed for the double-click-to-center feature

workaround:
in EditorControls.js manually edit line 96
scope.transitionSpeed = 0.00025;

(note that changing line 111 does not have any effect since it is presumably set in 96)

ui considerations - where to put this? some ideas:

  • in the toolbar, a toggle between immediate (lightning / no transition), fast (rabbit / current behavior), and slow (turtle) the latter two similar to dji drone speeds
  • as a property in a component on the Viewer layer (perhaps as part of converting this transition animation from a fakeComponent to a real component) -- advantage, no new UI is needed, simply let user set a value
@github-project-automation github-project-automation bot moved this to Backlog (Not Ready) in 3DStreet Dev Tracking Sep 10, 2024
@kfarr kfarr moved this from Backlog (Not Ready) to To Do - High Prio in 3DStreet Dev Tracking Sep 10, 2024
@vincentfretin
Copy link
Collaborator

Oh, that's a leftover during my tests. The line 96 should be removed really, and keep only line 111.

@vincentfretin
Copy link
Collaborator

I'll keep that need in mind when rewriting that code to a real component on a real entity for the Viewer layer in #851 probably use the following schema
{name: 'speed', oneOf: ['immediate', 'fast', 'slow'], default: 'fast' }

@vincentfretin vincentfretin self-assigned this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do - High Prio
Development

No branches or pull requests

2 participants