Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename layers-2d to reference-layers #322

Closed
kfarr opened this issue Aug 3, 2023 · 1 comment
Closed

rename layers-2d to reference-layers #322

kfarr opened this issue Aug 3, 2023 · 1 comment
Assignees
@Algorush

Comments

@kfarr
Copy link
Collaborator

kfarr commented Aug 3, 2023 •
edited
Loading

why? 2d layers is not a great name, instead "reference layers" is more accurate to depict layers that are references of real-world maps, 3d scans, 2d engineering drawings, etc.

new name:
dom id: "reference-layers" instead of "layers-2d"
data-layer-name for users: "Reference Layers"
js variable name referenceEntities instead of layers2DElement
@github-project-automation github-project-automation bot moved this to Not Ready To Do in 3DStreet Dev Tracking Aug 3, 2023
@kfarr kfarr moved this from Not Ready To Do to To Do in 3DStreet Dev Tracking Aug 3, 2023
@kfarr kfarr moved this from To Do to For Review in 3DStreet Dev Tracking Aug 8, 2023
@kfarr
Copy link
Collaborator Author

kfarr commented Aug 8, 2023

closed by #326

@kfarr kfarr closed this as completed Aug 8, 2023
@github-project-automation github-project-automation bot moved this from For Review to Done in 3DStreet Dev Tracking Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Algorush Algorush

Labels
None yet
Projects
3DStreet Dev Tracking
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfarr @Algorush