Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RR review #3

Open
rarichardson92 opened this issue Oct 24, 2018 · 0 comments
Open

RR review #3

rarichardson92 opened this issue Oct 24, 2018 · 0 comments

Comments

@rarichardson92
Copy link

Hey Trevor! Well done! Couple of thoughts in your code listed below:
The terming is a touch confusing for the general outline, but a solid strategy from what I can tell that covers all the points. Will need to define when “out of range” for PCR duplicates in step 5, flesh out the CIGAR +/- strategy, and how to purge parts of the dictionary as lines become “out of range” since it is being read line by line and dictionaries aren’t ordered.
I think for your function the processing for 5S85M1000N10S is a little off? While 95 is the number of M+S, you’ll need to take N into account as well! The below examples would technically be duplicates (forgive potential spacing changes from format):
<-------- ----- 5S40M100000N20M
<--- 80S20M
(Also it would be more reasonable in this case to see it as a 5S85M since both the N and S don’t actually align and shouldn’t be mapping back to anywhere)
Anyway, I have been frustrated by error correction in the last assignment, I look forward to seeing your method and hope it works better than mine did! Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant