Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Wrong TS Types for response from sdk.getRoomService().createRoom(args) #5

Open
tylerzey opened this issue Oct 31, 2022 · 0 comments

Comments

@tylerzey
Copy link

tylerzey commented Oct 31, 2022

I'm receiving the following back from 100ms after calling create room:

{
  id: 'xxx',
  name: 'yyy',
  enabled: true,
  description: 'yyy',
  customer_id: 'xxx',
  recording_source_template: true,
  enabled_source_template: true,
  recording_info: null,
  template_id: '',
  template: '',
  region: 'us',
  created_at: '2022-10-31T15:22:41.01Z',
  updated_at: '2022-10-31T15:22:40.55Z',
  customer: 'xxx'
}

The typescript response interface is

export interface HMSRoom {
    id: string;
    name: string;
    description: string;
    active: boolean;
    recording_info: {
        enabled: boolean;
    };
    user_id: string;
    customer_id: string;
    created_at: string;
    updated_at: string;
}

There are quite a few difference between these two objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant