Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

Feature Request: Top Level API for controlling remote peers screensharing #634

Open
tylerzey opened this issue Nov 9, 2022 · 3 comments

Comments

@tylerzey
Copy link

tylerzey commented Nov 9, 2022

Is your feature request related to a problem? Please describe.
Roles currently allow individuals to control remote audio and video settings. However, they do not allow a role to control a remove user's screenshare. It looks like the demo application uses a custom event workaround as seen here:

https://github.com/100mslive/100ms-web/blob/f67d7aabf39595234a8f60a96becb874250104ce/src/plugins/RemoteStopScreenshare.jsx

Describe the solution you'd like
It would be great if this was a top-level feature just like muting a remote peers audio/video

Describe alternatives you've considered
I could use the custom event method.

@arjunattam
Copy link

Thanks for sharing this request @tylerzey - we're looking into it. Any downside that you ran into with the workaround?

@tylerzey
Copy link
Author

Hi @arjunattam!

Thanks for writing back.

Yes, there is one downside. Unlike audio permissions that are controlled on a role basis, now, technically any role can emit this event and stop anyone's video.

While it's unlikely given my use case for this to be abused, the current implementation is very much a workaround.

Also, when first implementing 100ms, it's odd to see APIs support av controls:

hmsActions.setRemoteTrackEnabled
hmsActions.changeRole
hmsActions.removePeer

But then nothing for screen sharing.

@arjunattam
Copy link

Got it, thanks for the inputs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants