Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve macos testing in CI/CD #386

Open
FabijanC opened this issue Jun 22, 2023 · 1 comment
Open

Improve macos testing in CI/CD #386

FabijanC opened this issue Jun 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented Jun 22, 2023

Currently we rely on the venv-tests group, but it's very reduced. E.g. we should test how integrated tools can be used there: cairo1 compiler, scarb, integrated devnet

One problem I ran into while trying to add a scarb test: declaring a cairo 1 contract required devnet to be able to recompile, and it couldn't do so because the default starknet-sierra-compiler from the cairo-lang package is an executable compatible only with x86 (and our executor on circleci is m1 I believe). Using the installed cairo 1 compiler was not an option because it's only installed in configuration-tests.

Currently the only way to test if something works on mac is to have it tested by a developer with a mac machine.

@FabijanC FabijanC added the enhancement New feature or request label Jun 22, 2023
@FabijanC
Copy link
Collaborator Author

Proposition: each test could have a JSON file where target OS can be specified. Similar to how target networks are specified in network.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant