Unused import warnings

[FabijanC]

Warning

For some time now, we've had the issue of two imports reported in mod test_unique_auto_deletable_file in crates/starknet-devnet/tests/common/utils.rs:

starknet-devnet-rs/crates/starknet-devnet/tests/common/utils.rs

Line 338 in eb8d800

use std::path::Path;

Our check scripts don't consider this file; it's only reported by VS Code's rust-analyzer.

Reproduce

When I run cargo check --all-targets, I get this (omitted parts are replaced with [...]):

warning: unused import: `std::path::Path`
   --> crates/starknet-devnet/benches/../tests/common/utils.rs:338:9
[...]
warning: `starknet-devnet` (bench "mint_bench") generated 2 warnings [...]

Cause

Notice how it reports the warnings as belonging to mint_benches in benches. This is due to a pub mod common annotation in mint_bench.rs:

starknet-devnet-rs/crates/starknet-devnet/benches/mint_bench.rs

Line 6 in eb8d800

#[path = "../tests/common/mod.rs"]

Without the mod path manipulation, the warnings are gone.

Questions

1. Are these tests even executed in our CI? I don't see them mentioned in the logs.
2. Are there any other tests not executed?
3. Should we add an --all-targets check?

Mitigation

1. Sure we could just [allow(...)] the two warnings, but I'd prefer something better.
2. Perhaps we could just move the test_unique_auto_deletable_file module.
3. While googling, I found this recommendation on integration test organization, which could even reduce the testing time (hence the performance label I'm putting on this issue).
4. We could also remove the bench file, I don't think we've ever used it, and I don't think it's a part of our CI.