-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnecessary derive #188
Comments
hey, I can take a look if this is still available |
@greged93 sure! |
@greged93 any progress? |
hey @ivpavici, got side tracked, if you need this urgently then better to remove me, otherwise can do it this week-end |
ok if you want to continue lets see next week! |
hello @ivpavici i would love to work on this |
@g4titanx we will wait for the ODHack to commence |
alright! |
hello @ivpavici can you assign the task to me now? |
@g4titanx only one assignee per issue! |
Hi @ivpavici . I can work on this. |
I realized we put a lot of unnecessary
#[derive]
attributes to our struct definitions. I believe this increases both the compilation time and the binary size. E.g. some structs are only serialized, so they don't need#[derive(Deserialize)]
.Perhaps we could only add these attributes when we really need them. To completely resolve this task, someone would need to go through all the structs and see if the derivation of some traits can be removed.
Let me know if I'm wrong and this doesn't have such an impact as it seems to me.
The text was updated successfully, but these errors were encountered: