Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary derive #188

Open
FabijanC opened this issue Sep 29, 2023 · 11 comments
Open

Unnecessary derive #188

FabijanC opened this issue Sep 29, 2023 · 11 comments
Labels
Easy Task is easy to fix enhancement New feature or request OnlyDust

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Sep 29, 2023

I realized we put a lot of unnecessary #[derive] attributes to our struct definitions. I believe this increases both the compilation time and the binary size. E.g. some structs are only serialized, so they don't need #[derive(Deserialize)].

Perhaps we could only add these attributes when we really need them. To completely resolve this task, someone would need to go through all the structs and see if the derivation of some traits can be removed.

Let me know if I'm wrong and this doesn't have such an impact as it seems to me.

@FabijanC FabijanC added the enhancement New feature or request label Sep 29, 2023
@FabijanC FabijanC mentioned this issue Dec 11, 2023
10 tasks
@greged93
Copy link

greged93 commented Feb 5, 2024

hey, I can take a look if this is still available

@ivpavici
Copy link
Contributor

ivpavici commented Feb 5, 2024

@greged93 sure!

@ivpavici
Copy link
Contributor

@greged93 any progress?

@greged93
Copy link

hey @ivpavici, got side tracked, if you need this urgently then better to remove me, otherwise can do it this week-end

@ivpavici
Copy link
Contributor

ok if you want to continue lets see next week!

@g4titanx
Copy link

hello @ivpavici i would love to work on this

@ivpavici ivpavici added the ODHack Issue to assign for the ODHack event label Apr 19, 2024
@ivpavici
Copy link
Contributor

@g4titanx we will wait for the ODHack to commence

@g4titanx
Copy link

alright!

@ivpavici ivpavici added the Easy Task is easy to fix label Apr 19, 2024
@g4titanx
Copy link

hello @ivpavici can you assign the task to me now?

@ivpavici
Copy link
Contributor

@g4titanx only one assignee per issue!

@fishonamos
Copy link

Hi @ivpavici . I can work on this.

@fishonamos fishonamos removed their assignment May 2, 2024
@ivpavici ivpavici removed the ODHack Issue to assign for the ODHack event label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Task is easy to fix enhancement New feature or request OnlyDust
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants