Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't compile a regex in a loop in trie_diff #721

Open
0xaatif opened this issue Oct 13, 2024 · 1 comment · May be fixed by #758
Open

Don't compile a regex in a loop in trie_diff #721

0xaatif opened this issue Oct 13, 2024 · 1 comment · May be fixed by #758
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Milestone
System strengthening

Comments

@0xaatif
Copy link
Contributor

0xaatif commented Oct 13, 2024 •
edited
Loading

zk_evm/zero/src/bin/trie_diff.rs

Line 133 in 177ae27

let re = Regex::new(r"block:(\d+) batch:(\d+)")?;

https://docs.rs/lazy-regex/latest/lazy_regex/macro.regex_captures.html

Let's also get rid of the indexing and use a nice library for this
@0xaatif
Copy link
Contributor Author

0xaatif commented Oct 13, 2024

cc @atanmarko

@0xaatif 0xaatif added the crate: zero_bin Anything related to the zero-bin subcrates. label Oct 13, 2024
@0xaatif 0xaatif added this to the System strengthening milestone Oct 13, 2024
@sergerad sergerad linked a pull request Oct 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Backlog
Milestone
System strengthening
Development

Successfully merging a pull request may close this issue.

Replace regex in trie diff main sergerad/zk_evm
1 participant
@0xaatif