Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some testing issues #146

Open
paulgoleary opened this issue Oct 26, 2024 · 2 comments
Open

[BUG] Some testing issues #146

paulgoleary opened this issue Oct 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@paulgoleary
Copy link
Collaborator

Found some potential issues testing with production data around sendCertificate. Capturing here to follow up.

  • Large numbers in bridge table - likely others - choke meddler
    • e.g. 1.5e+19 These numbers appear to be valid.
    • Haven't found a good remediation. The sqlite type is DECIMAL(78, 0) but the type returned from the internal query is string. Then big.Int.SetString fails because it doesn't support exponent in the string.
  • Logical inconsistency: shouldSendCertificate checks that there are no pending certs. But then GetLastSentCertificate filters and only selects pending certs.
    • The net result is that sendCertificate only sends one cert and then doesn't send again
    • My fix (workaround?) is to remove the PENDING predicate from GetLastSentCertificate
  • Got code generating test certs from production data. Not sure if they are 'valid' because - for instance - don't seem to see any claims yet.
    • Q: are we indexing old claim format? If not, might want to for testing purposes.
@paulgoleary paulgoleary added the bug Something isn't working label Oct 26, 2024
@vcastellm
Copy link
Contributor

Large numbers in bridge table - likely others - choke meddler

  • e.g. 1.5e+19 These numbers appear to be valid.
  • Haven't found a good remediation. The sqlite type is DECIMAL(78, 0) but the type returned from the internal query is string. Then big.Int.SetString fails because it doesn't support exponent in the string.

See this comment https://github.com/0xPolygon/cdk/pull/22/files#r1816496554 I think that's should be the way to go

@goran-ethernal
Copy link
Collaborator

@paulgoleary First two points are solved, and are merged to the develop branch on cdk repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants