Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array index out of bounds not handled #4

Open
0x787af25e opened this issue Apr 14, 2023 · 1 comment
Open

Array index out of bounds not handled #4

0x787af25e opened this issue Apr 14, 2023 · 1 comment

Comments

@0x787af25e
Copy link
Owner

0x787af25e commented Apr 14, 2023

image.png

When I attempted to edit entry 0, GoodMatch threw a generic error message.

@nus-pe-script
Copy link

nus-pe-script commented Apr 17, 2023

Team's Response

We did specify in the error message that the index "must be a positive integer within the range of the number of listings shown". However, we do recognise that we made a typo in the UserGuide and did not change one of the "non-negative" to "positive". For that we feel like the severity of the issue should not be Low but should be VeryLow since it was a typo issue and that while using the app which is what users will be interacting with is the application and the error message on the application is correct.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants