Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Add URI parsing for GitHub repositories #509

Open
Lamparter opened this issue Sep 3, 2024 · 2 comments
Open

Spec: Add URI parsing for GitHub repositories #509

Lamparter opened this issue Sep 3, 2024 · 2 comments
Assignees
Labels
type/spec This issue is a specification for enhancements

Comments

@Lamparter
Copy link
Collaborator

📄 Description

We should add URI parsing to FluentHub as this will allow native support for handling and opening GitHub repos in FluentHub via the browser, in shell context menu APIs and external apps such as Files and the UWP Companion.

⚡ API Changes

TODO

👥 Usage scenarios

Web URI

Here are a few proposals:

  1. fluenthub://github.com/{Repo.Owner.Login}/{Repo.Name}
  2. fluenthub://https://github.com/{Repo.Owner.Login}/{Repo.Name}
  3. fluenthub://openRepository?repo={Repo.Owner.Login}/{Repo.Name}
  4. fluenthub://openRepository?repo=https://github.com/{Repo.Owner.Login}/{Repo.Name}
  5. fluenthub://{Repo.Owner.Login}/{Repo.Name}

Personally options 1 and 5 are my favourite. What do you think @0x5bfa?

🔙 Backward Compatibility

This does not change APIs and instead only introduces them.

✅ Tasks

TODO

🤔 Difficulty

Medium

@Lamparter Lamparter added the type/spec This issue is a specification for enhancements label Sep 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 To do in FluentHub Board Sep 3, 2024
@Lamparter Lamparter pinned this issue Sep 3, 2024
@0x5bfa
Copy link
Owner

0x5bfa commented Sep 3, 2024

FluentHub:///repo?files-community/Files sounds good to me. We use 'auth' for redirecting to the app when authenticating, this way can reserve path strings to use them ourselves.

@Lamparter
Copy link
Collaborator Author

FluentHub:///repo?files-community/Files sounds good to me. We use 'auth' for redirecting to the app when authenticating, this way can reserve path strings to use them ourselves.

Ooh yes forgot about the reserved strings. There's no user named 'auth' because it's reserved by GitHub though, this is the reason Files org is called 'files-community' and not just Files.

The reason i liked option 1 is because a) it looks like HTTP resource headers and b) it allows the user to put just put fluenthub:// in front of a GitHub URL to open FluentHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/spec This issue is a specification for enhancements
Projects
Status: 📋 To do
Development

No branches or pull requests

2 participants