Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: App crashes when repository opened in a non-existent application #495

Open
Tracked by #488
Lamparter opened this issue Jul 23, 2024 · 6 comments · May be fixed by #504 or #486
Open
Tracked by #488

Bug: App crashes when repository opened in a non-existent application #495

Lamparter opened this issue Jul 23, 2024 · 6 comments · May be fixed by #504 or #486
Assignees
Labels
type/crash This issue reports a crash of the app

Comments

@Lamparter
Copy link
Collaborator

🪟 What version of Windows is this issue present?

🪟 Windows 11

🔢 What version of FluentHub are you on?

0.8.60.0 | X64 | DEBUG
(This does not affect the error)

📄 Description

App crashes when opening GitHub Desktop/Visual Studio from the repository Clone context menu if the appropriate app is not installed.

🪜 Steps To Reproduce

  1. Navigate to a repo
  2. Press on the Clone button
  3. From the context menu, open the repo in an app you do not have installed (Visual Studio or GitHub Desktop as appropriate)
  4. App crashes.

🤔 Expected behavior

App should check for application install and grey out the button or open a browser with arguments for the URI which would prevent app crash.

⚒️ Did you find any workaround?

No response

📑 Stack Trace

Stack trace is not associated with this error.

📸 Assets

Screen.Recording.2024-07-23.151803.mp4
As you can see, the app crashes when the user attempts to open the repository with GitHub Desktop which is not installed on the machine.
@Lamparter Lamparter added the type/crash This issue reports a crash of the app label Jul 23, 2024
@Lamparter Lamparter added this to the FluentHub v1.0.0 milestone Jul 23, 2024
@Lamparter Lamparter self-assigned this Jul 23, 2024
@github-project-automation github-project-automation bot moved this to 📋 To do in FluentHub Board Jul 23, 2024
@Lamparter

This comment was marked as outdated.

@0x5bfa

This comment was marked as outdated.

@Lamparter

This comment was marked as outdated.

@0x5bfa

This comment was marked as outdated.

@Lamparter

This comment was marked as outdated.

This was linked to pull requests Aug 29, 2024
@Lamparter
Copy link
Collaborator Author

Real? Why not just send user to GitHub Desktop download page.

@0x5bfa I'll just try other clients on error and if still fails, show GitHub Desktop download page.

Lamparter added a commit that referenced this issue Aug 30, 2024
Lamparter added a commit that referenced this issue Sep 7, 2024
@Lamparter Lamparter linked a pull request Sep 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/crash This issue reports a crash of the app
Projects
Status: 📋 To do
Development

Successfully merging a pull request may close this issue.

2 participants